Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(inputs.net): Clarify option deprecation notice #15364

Merged

Conversation

DStrand1
Copy link
Member

Summary

Clarifies the deprecation notice for the ignore_protocol_stats option to be more clear about only the option being deprecated, not the plugin

Checklist

  • No AI generated code was used in this PR

@DStrand1 DStrand1 added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label May 15, 2024
@telegraf-tiger telegraf-tiger bot added chore plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels May 15, 2024
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it, thanks!

@powersj powersj removed their assignment May 15, 2024
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks @DStrand1!

@srebhan srebhan merged commit 5607934 into influxdata:master May 16, 2024
27 checks passed
@github-actions github-actions bot added this to the v1.30.3 milestone May 16, 2024
powersj pushed a commit that referenced this pull request May 20, 2024
@DStrand1 DStrand1 deleted the inputs.net-deprecation-clarification branch October 11, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants