-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Fix typos throughout codebase #15338
Conversation
Thanks so much for the pull request! |
Hi,
Please don't mess with the checklist. We do need that checked and accurate. Also as the bot said, please do sign the CLA and let us know when you do. Thanks |
I am sorry. |
Submitted 🍏 |
!signed-cla
No worries! |
!signed-cla |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @szepeviktor for your contribution and effort! Please do not change TOML tags as this will break compatibility to existing configurations, something we don't want to do. You should rather deprecate the misspelled config setting and add a new one (just like what is done in the "binary" parser)...
plugins/inputs/cloudwatch_metric_streams/cloudwatch_metric_streams.go
Outdated
Show resolved
Hide resolved
@srebhan I am sorry. Reverting manually takes hours. Now I am starting over again based on your comments. |
For the willing contributor: [files]
extend-exclude = [
".git/",
"go.mod",
"go.sum",
"CHANGELOG.md",
"**/testcases/**",
"**/testdata/**",
"plugins/inputs/zfs/README.md",
]
ignore-hidden = false
[default]
extend-ignore-re = [
"logical-ANDed",
"\\$ecret-Passw0rd",
]
[default.extend-words]
"aproxs" = "approxs"
"aer" = "aer"
"bck" = "bck"
"iif" = "iif"
"oif" = "oif"
"pn" = "pn"
"rto" = "rto"
"siz" = "siz"
"wrk" = "wrk"
"endianess" = "endianess"
"mosquitto" = "mosquitto"
"splitted" = "splitted"
# Known typos
"celcius" = "celcius"
"compatability" = "compatability"
"diagnotics" = "diagnotics"
"uncorrect" = "uncorrect"
[default.extend-identifiers]
"TLS_RSA_WITH_3DES_EDE_CBC_SHA" = "TLS_RSA_WITH_3DES_EDE_CBC_SHA"
"TLS_ECDHE_RSA_WITH_3DES_EDE_CBC_SHA" = "TLS_ECDHE_RSA_WITH_3DES_EDE_CBC_SHA"
"Ip6InECT0Pkts" = "Ip6InECT0Pkts"
"Ip6InECT1Pkts" = "Ip6InECT1Pkts"
"icmpInParmProbs" = "icmpInParmProbs"
"IcmpInParmProbs" = "IcmpInParmProbs"
"icmpOutParmProbs" = "icmpOutParmProbs"
"IcmpOutParmProbs" = "IcmpOutParmProbs"
"idel_per_s" = "idel_per_s"
"network_idel_per_s" = "network_idel_per_s"
# Known typos
"TCMallocPageheapComittedBytes" = "TCMallocPageheapComittedBytes"
# Typos
##"Github" = "GitHub" |
@szepeviktor why do you start over and why does it take hours? You just need to fix the few places I commented!?!? |
@powersj maybe we could use the software mentioned to add a GitHub action for checking spelling? |
Typos fixes typos. To revert a fix I have to search for each occurrence. |
@szepeviktor you could manually correct the few occurrences in the git branch. No need to rerun the tool... Am I missing something? |
The thing is typos work on the filesystem, not on git index. I've already redone everything. |
@szepeviktor let me be clear. You do have the present git-branch leading to this PR... Now why can't you fire-up an editor with the branch checked out and manually revert the changes in the files I mentioned without running typos again? I don't see why this is a lot of work, it's just opening an editor and changing eight lines back to what they were before!?!?!? |
When I work with typos the most of work is done by typos. |
@srebhan Is this PR okay in the current form? |
Tests need to pass. Current failure:
|
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two items that probably should not be changed.
I did not see any TOML tags that changed. most of the items were limited to comments, docs, and unexported variables. In the cases were it was a exported variable it looked fine.
plugins/inputs/gnmi/extensions/jnpr_gnmi_extention/GnmiJuniperTelemetryHeaderExtension.pb.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@srebhan I'm going to leave the final +1 to you
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @szepeviktor for your contribution and thanks @powersj for driving this over the finish line!
Glad to contribute. |
Summary
Found few misspellings.
Checklist
Please be gentle with me, I've gone through 500k lines.