Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add backpressure to GroupBy [WriteApi] #358

Merged
merged 19 commits into from
Jul 19, 2022
Merged

fix: add backpressure to GroupBy [WriteApi] #358

merged 19 commits into from
Jul 19, 2022

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Jun 1, 2022

Closes #168
Closes #202
Closes #357

Proposed Changes

This PR fixes missing backpressure in groupBy operator after update RxJava to `v3.

For more info see:

Testing Snapshot

Testing snapshots are deployed into OSS Snapshot repository as a version 6.2.0.groupBy-SNAPSHOT.

Maven

<repository>
    <id>ossrh</id>
    <name>OSS Snapshot repository</name>
    <url>https://oss.sonatype.org/content/repositories/snapshots/</url>
    <releases>
        <enabled>false</enabled>
    </releases>
    <snapshots>
        <enabled>true</enabled>
    </snapshots>
</repository>

Gradle

repositories {
    maven { url "https://oss.sonatype.org/content/repositories/snapshots" }
}

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • mvn test completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2022

Codecov Report

Merging #358 (76ccc75) into master (77fb8db) will decrease coverage by 0.72%.
The diff coverage is 78.08%.

@@             Coverage Diff              @@
##             master     #358      +/-   ##
============================================
- Coverage     89.63%   88.91%   -0.73%     
- Complexity      729      778      +49     
============================================
  Files           167      169       +2     
  Lines          6590     6864     +274     
  Branches        327      364      +37     
============================================
+ Hits           5907     6103     +196     
- Misses          591      653      +62     
- Partials         92      108      +16     
Impacted Files Coverage Δ
...nternal/flowable/FlowableBufferTimedFlushable.java 70.68% <70.68%> (ø)
...al/flowable/BackpressureBatchesBufferStrategy.java 75.57% <75.57%> (ø)
.../influxdb/client/internal/AbstractWriteClient.java 89.47% <92.42%> (-5.27%) ⬇️
...nfluxdb/client/write/events/BackpressureEvent.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77fb8db...76ccc75. Read the comment docs.

@bednar bednar force-pushed the groupBy branch 2 times, most recently from 5402d1d to 48c5031 Compare June 29, 2022 05:53
@bednar bednar marked this pull request as ready for review June 29, 2022 08:27
@bednar bednar requested a review from rhajek June 29, 2022 08:27
@bednar bednar mentioned this pull request Jul 18, 2022
@bednar bednar merged commit 2c8e6dd into master Jul 19, 2022
@bednar bednar deleted the groupBy branch July 19, 2022 07:02
@bednar bednar added this to the 6.4.0 milestone Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants