-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add backpressure to GroupBy [WriteApi] #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #358 +/- ##
============================================
- Coverage 89.63% 88.91% -0.73%
- Complexity 729 778 +49
============================================
Files 167 169 +2
Lines 6590 6864 +274
Branches 327 364 +37
============================================
+ Hits 5907 6103 +196
- Misses 591 653 +62
- Partials 92 108 +16
Continue to review full report at Codecov.
|
bednar
force-pushed
the
groupBy
branch
2 times, most recently
from
June 29, 2022 05:53
5402d1d
to
48c5031
Compare
Closed
rhajek
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #168
Closes #202
Closes #357
Proposed Changes
This PR fixes missing backpressure in
groupBy
operator after updateRxJava
to `v3.For more info see:
Testing SnapshotTesting snapshots are deployed into OSS Snapshot repository as a version6.2.0.groupBy-SNAPSHOT
.MavenGradleChecklist
mvn test
completes successfully