Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please verify the following:
yarn test
jest tests pass with new tests, if relevantyarn lint
eslint checks pass with new code, if relevantyarn format:check
prettier checks pass with new code, if relevantREADME.md
(or relevant documentation) has been updated with your changesDescribe your PR
This PR addresses potential issues with the loadString function in our storage module. Previously, the function might have failed silently or returned unexpected results when the key was not found in storage. The following changes have been made:
• Added an explicit check for undefined to ensure we return null if the key is not found.
• Included error handling with a console.error log in case of unexpected failures while reading from storage.
Why this change?:
This change improves the reliability of the loadString function and helps to debug any issues with data fetching from storage. It also prevents returning undefined when the key is not found, providing more predictable behavior.