Fix plugin #7
Fix plugin #7
Conversation
Since XWalkCordovaWebView doesn't extend XWalkView, needs to use getView() to get the XWalkView instance.
Fix: 1. Enable the webview client and chrome client. 2. Fix setNetworkAvailable bridge.
This prefix is used to construct class names of WebView, WebViewClient and ChromeClient.
This reverts commit 789d612.
|
This PR depends on https://github.com/infil00p/cordova-android/pull/3 to work. |
| @@ -18,7 +18,7 @@ | |||
| <!-- android --> | |||
| <platform name="android"> | |||
| <config-file target="res/xml/config.xml" parent="/*"> | |||
| <preference name="webView" value="org.apache.cordova.engine.crosswalk.XWalkCordovaWebView" /> | |||
| <preference name="webView" value="org.apache.cordova.engine.crosswalk.XWalkCordova" /> | |||
There was a problem hiding this comment.
I don't understand this change -- there isn't a class in the source tree named org.apache.cordova.engine.crosswalk.XWalkCordova; doesn't it need to be the name of the WebView class?
There was a problem hiding this comment.
This is a workaround. I would like to go with your solution which delegates the ChromeClient and WebClient constructions to webview engine.
|
Implement the makeChromeClient and makeWebViewClient delegation. @clelland , please take another look. Thanks. |
|
@clelland , you mentioned you run cordova-crosswalk-engine successfully (http://callback.markmail.org/search/?q=Success+with+Crosswalk+Engine#query:Success%20with%20Crosswalk%20Engine+page:1+mid:hhhaimmmlaesl5lu+state:results). Could you please send your PR to merge? Or I can close this one. Let's move forward. Thanks. |
Don't pause timers when app is backgrounded.
|
It seems that everything is working fine for me, so I think you can close it. |
No description provided.