Skip to content
This repository has been archived by the owner on Jun 2, 2018. It is now read-only.

Fix plugin #7

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fix plugin #7

wants to merge 6 commits into from

Conversation

huningxin
Copy link
Contributor

No description provided.

Since XWalkCordovaWebView doesn't extend XWalkView, needs to use getView() to
get the XWalkView instance.
Fix:
1. Enable the webview client and chrome client.
2. Fix setNetworkAvailable bridge.
This prefix is used to construct class names of WebView, WebViewClient and
ChromeClient.
@huningxin
Copy link
Contributor Author

This PR depends on https://github.com/infil00p/cordova-android/pull/3 to work.

@huningxin
Copy link
Contributor Author

@infil00p @clelland, PTAL! Thanks.

@@ -18,7 +18,7 @@
<!-- android -->
<platform name="android">
<config-file target="res/xml/config.xml" parent="/*">
<preference name="webView" value="org.apache.cordova.engine.crosswalk.XWalkCordovaWebView" />
<preference name="webView" value="org.apache.cordova.engine.crosswalk.XWalkCordova" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand this change -- there isn't a class in the source tree named org.apache.cordova.engine.crosswalk.XWalkCordova; doesn't it need to be the name of the WebView class?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a workaround. I would like to go with your solution which delegates the ChromeClient and WebClient constructions to webview engine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted.

@huningxin
Copy link
Contributor Author

Implement the makeChromeClient and makeWebViewClient delegation. @clelland , please take another look. Thanks.

@huningxin
Copy link
Contributor Author

ping @clelland @infil00p

@huningxin
Copy link
Contributor Author

@clelland , you mentioned you run cordova-crosswalk-engine successfully (http://callback.markmail.org/search/?q=Success+with+Crosswalk+Engine#query:Success%20with%20Crosswalk%20Engine+page:1+mid:hhhaimmmlaesl5lu+state:results). Could you please send your PR to merge? Or I can close this one. Let's move forward. Thanks.

infil00p pushed a commit that referenced this pull request Dec 8, 2014
Don't pause timers when app is backgrounded.
@jesusprubio
Copy link

It seems that everything is working fine for me, so I think you can close it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants