Add NaN/Inf checks into check_numpy_array_features #1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For normal scenario (and provide a killer switch to turn off the check), all numpy arrays should not have NaN or Inf.
|
Thanks! I agree that this is a good idea. I can't really merge it right now, since it might lower students' grades. But I've set a reminder for the end of the semester to merge it then (and rebuild the container image). Also, looks like you've got a linter failure. Could you look into it? |
Update doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For normal scenario (and provide a killer switch to turn off the check), all numpy arrays should not have NaN or Inf.