Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipython notebook uploads #1047

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ipython notebook uploads #1047

wants to merge 1 commit into from

Conversation

lukeolson
Copy link
Collaborator

  • add ipynb mimetype
  • check that json loads
  • check that json has nbformat >= 4

inducer
inducer reviewed Feb 14, 2024
View reviewed changes
course/page/upload.py Outdated Show resolved Hide resolved
course/page/upload.py Outdated Show resolved Hide resolved
course/page/upload.py Outdated Show resolved Hide resolved
course/page/upload.py Outdated Show resolved Hide resolved
@inducer
Copy link
Owner

inducer commented Feb 16, 2024

LMK when this is ready to look at/merge. So far, I'm refraining from taking a detailed look while it's still in draft status.

@lukeolson lukeolson marked this pull request as ready for review February 16, 2024 21:04
@lukeolson
Copy link
Collaborator Author

LMK when this is ready to look at/merge. So far, I'm refraining from taking a detailed look while it's still in draft status.

Go ahead now. I've tested the functionality locally. If a unit test would help, I'll add.

@lukeolson
Copy link
Collaborator Author

Any else needed here?

inducer
inducer reviewed Feb 28, 2024
View reviewed changes
Copy link
Owner

@inducer inducer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one wrinkle, then this should be good.

course/page/upload.py Outdated Show resolved Hide resolved
@inducer inducer enabled auto-merge (rebase) July 30, 2024 15:33
@inducer inducer disabled auto-merge July 30, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inducer inducer inducer left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukeolson @inducer