Nmea #536
Nmea #536
Conversation
|
I reviewed your PR and I am not ready to accept it. I experimented with mixing GLONASS and GPS before but the results were not good as both systems did not return absolutely the same values. This leads to some problems synchronizing mounts so I did not release this experiment and I decided to make a switch property to choose between the sysmes to use but I never did it as there was no urge for this. This will also fix the issue with the reported SVs in use etc. Can you make your PR so that one can choose the system to use and parse messages only from the selected system and ignore the rest? You can add a ONE_OF_MANY switch to choose from GPS GLONAS etc. |
|
I think this property has to have an "Automatic" default item, where the first system providing a fix would be selected. As the vast majority of receivers either provide a fix for one constellation only, or only a "GN" fix combining several constellations, this automatic selection should be enough for most users. And a manual selection would allow the unlucky other few to get the driver working with their receivers. |
|
No rush!
…On Tue, May 21, 2024 at 10:37 AM Jean-Etienne Lamiaud < ***@***.***> wrote:
I think this property has to have an "Automatic" default item, where the
first system providing a fix would be selected. As the vast majority of
receivers either provide a fix for one constellation only, or only a "GN"
fix combining several constellations, this automatic selection should be
enough for most users. And a manual selection would allow the unlucky other
few to get the driver working with their receivers.
I'm working on it, but do not have much time at the moment.
—
Reply to this email directly, view it on GitHub
<#536 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE5EZBM7TTZE4JCZVPSXTPTZDL2VFAVCNFSM6AAAAABH5VF2HOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRRHE2TQMRSGA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
I've added the property for NMEA system selection. The "Multiple" case (Talker Id "GN") still needs some specific processing, because it mixes a fix (RMC and GGA) with GN talker id, and satellites data (GSA and GSV) with all used constellations Talker Ids. |
The current code only accepts NMEA sentences referencing GPS and GNSS systems. Most receivers also use Galilleo (but generally identifying it as GPS), GLONASS, and possibly Beidu. When the receiver emits these sentences, an error log is written; which makes the log filled with two or three error lines per seconds, with a perfectly correct receiver.
The first commit simply downgrade the log to debug, as this is not an error. I also have changed the order of the tests to check for the "nothing received" case, before checking if the received sentence was parsed.
The second commit is more experimental, to process sentences from all kind of systems. With my GPS/Gallileo/GLONASS receiver, it works fine: the number of satellites in view comprises all constellations, and all other data is still correctly reported.