Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grpc-native-support #296

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

grpc-native-support #296

wants to merge 3 commits into from

Conversation

leehol
Copy link

@leehol leehol commented Jan 31, 2022

Changes

  • Added grpc native support based. on this repo
  • Includes new service (grpcnative.ts, parameters.ts, index.ts)

Verification

Yes, js generated files tested with proto server

@improbable-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign easycz
You can assign the PR to them by writing /assign @easycz in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@improbable-prow-robot improbable-prow-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XXL Denotes a PR that changes 600+ lines, ignoring generated files. labels Jan 31, 2022
@leehol
Copy link
Author

leehol commented Jan 31, 2022

Hey all, just wondering why this hasn't been done given that improbable-eng also maintains this:
https://www.npmjs.com/package/@improbable-eng/grpc-web-react-native-transport

@leehol
Copy link
Author

leehol commented Jan 31, 2022

/assign @easyCZ

@leehol
Copy link
Author

leehol commented Feb 15, 2022

Any updates here? @tobyn @easyCZ @esilkensen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@easyCZ easyCZ Awaiting requested review from easyCZ

@MarcusLongmuir MarcusLongmuir Awaiting requested review from MarcusLongmuir

At least 1 approving review is required to merge this pull request.

Assignees

@easyCZ easyCZ

Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XXL Denotes a PR that changes 600+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@leehol @improbable-prow-robot @easyCZ