Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it clear how to install the plugin #2993

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

jwbth
Copy link

@jwbth jwbth commented Mar 28, 2024

The markup in README.md is misleading, as it puts several alternatives into one block of code while not making it clear where the alternatives begin and end, forcing the reader to think hard about it. The pull request splits the block of code into three isolated ones, preceding each one with a comment and organizing them in a list.

The markup was misleading, as it put several alternatives into one block of code while not making it clear where the alternatives begin and end, forcing the reader to think hard about it.
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.60%. Comparing base (c0ac54b) to head (ab88f4d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2993      +/-   ##
==========================================
- Coverage   95.66%   95.60%   -0.07%     
==========================================
  Files          78       78              
  Lines        3275     3275              
  Branches     1150     1150              
==========================================
- Hits         3133     3131       -2     
- Misses        142      144       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

It makes it more clear that this is a list of alternatives, not a list of steps.
@jwbth jwbth changed the title Make it more clear how to install the plugin Make it clear how to install the plugin Mar 28, 2024
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's convert these to json instead of yaml, while we're at it.

@ljharb ljharb added the docs label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants