Update MacroRecorderPostprocessor tests #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The LegacyService has a setter for its IJ1Helper. Tracking it separately in the DefaultLegacyHooks creates an opportunity for skew between its helper and the LegacyService's helper. The LegacyService has an accessor for its IJ1Helper instance so it is not necessary to cache it in the DefaultLegacyHooks. See #305
In my Windows environment (command line and IntelliJ) the MacroRecorderPostprocessor was not being registered as a postprocessor. Doing this seems necessary for the test to pass.
|
@ctrueden can you check if this works on your systems? |
ctrueden
reviewed
Jul 19, 2024
There was a problem hiding this comment.
All tests pass with this branch on my Linux system!
I see that all references to the helper variable have changed to access it dynamically from the LegacyService every time. But there is still a null check in at least one spot. Is the idea that the IJ1Helper can go from null to non-null or vice versa? If so, what if it happens in between the null check and the next dynamic access?
In case we want to do null checking in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #305 for me