Merge pull request #28 from ilyavolodin/render-return

Fixing empty return bug (Fixes #27)
ilyavolodin · Oct 17, 2014 · d618990 · d618990
2 parents 3161e1c + d7bddb9
commit d618990
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/lib/rules/render-return.js b/lib/rules/render-return.js
@@ -39,7 +39,7 @@ module.exports = function(context) {
         },
         "ReturnStatement": function(node) {
             if (inBackboneRender) {
-                returnFound = node.argument.type === "ThisExpression";
+                returnFound = node.argument && node.argument.type === "ThisExpression";
             }
         }
     };

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "eslint-plugin-backbone",
-    "version": "0.0.6",
+    "version": "0.1.0",
     "description": "Eslint rules for Backbone.",
     "main": "index.js",
     "scripts": {

diff --git a/tests/lib/rules/render-return.js b/tests/lib/rules/render-return.js
@@ -34,6 +34,10 @@ eslintTester.addRuleTest("lib/rules/render-return", {
         {
             code: "Backbone.View.extend({ render: function() { return 1; } });",
             errors: [ { message: "render method should always return 'this'" } ]
+        },
+        {
+            code: "Backbone.View.extend({ render: function() { return; } });",
+            errors: [ { message: "render method should always return 'this'" } ]
         }
     ]
 });