feat(client&server): add users and movement queries #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SirAuron
requested changes
Mar 6, 2024
packages/client/src/components/manage-users/edit-user-stockdata-dialog.vue
Show resolved
Hide resolved
Comment on lines
75
to
76
| :rows-per-page-options="ROWS_PER_PAGE_OPTIONS" | ||
| @request="onRequest" |
There was a problem hiding this comment.
For this table, we shall preserve the pagination selection and navigation, and so this piece here is necessary.
Along with the updated function inside the body of the component onRequest
There was a problem hiding this comment.
OK, implemented server-side pagination and filtering. Used a lazy query as it's more optimal. Currently, with the books service, we initially fire the query twice with no benefit. So, we have to change them as well. I faced a bug(vuejs/apollo#1540) during the process, left the link in a code comment. We can also make some updates to our plugin to improve DX with lazy queries. https://github.com/dreamonkey/graphql-codegen-stack/tree/main/packages/codegen-plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.