Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the UI Test Label Process #8147

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Conversation

jrjohnson
Copy link
Member

I think the "ready to merge" label was a bit off, we don't need to add any more automation to this process. It is working well as is today. Updating the label to "run ui tests" is more accurate.

I also removed the test to ensure the label is present, it's just annoying. We require the ui tests that are run before merging so it will need to get added eventually anyway.

I think the "ready to merge" label was a bit off, we don't need to add
any more automation to this process. It is working well as is today.
Updating the label to "run ui tests" is more accurate.

I also removed the test to ensure the label is present, it's just
annoying. We require the ui tests that are run before merging so it will
need to get added eventually anyway.
@jrjohnson jrjohnson added the run ui tests Run the expensive UI tests label Sep 20, 2024
@jrjohnson jrjohnson marked this pull request as ready for review September 20, 2024 23:50
Copy link
Member

@stopfstedt stopfstedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm on board with this.

@stopfstedt stopfstedt merged commit 3c166b0 into ilios:master Sep 24, 2024
40 checks passed
@jrjohnson jrjohnson deleted the relable-ui-tests branch September 24, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run ui tests Run the expensive UI tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants