Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirrored/flipped sprites' position if off by 1 pixel versus Mugen #1864

Open
Kasasagi77 opened this issue Jun 29, 2024 · 1 comment
Open

Comments

@Kasasagi77
Copy link
Contributor

Kasasagi77 commented Jun 29, 2024

Describe the bug

You can programatically mirror/flip sprites in Mugen in two ways that I know of:

  1. Using a negative scalestart, e.g. scalestart = -1,1.
  2. In the animation definition (air format), by using optional parameters H or V, e.g. 15,1, 0,0, 5, H.

In both of those cases the position of the mirrored/flipped sprite will be off-by-one in Ikemen in comparison to Mugen.

To Reproduce

I do not have a ready test case at this time, but I wanted to at least leave a note of the problem.

You can create your own test case (preferably lowres for easier visibility) by using the parameters described above and comparing with Mugen.

Expected behavior

Matching Mugen.

Screenshots / Video

No response

Engine Version (or source code date)

2024-06-29

Operating system

Linux

Extra context or search terms

No response

@potsmugen
Copy link
Contributor

potsmugen commented Jul 11, 2024

Simple char test case. Make this the standing animation of any char (preferably KFM):

[Begin Action 0]
9000,1, 0,-150, 1
9000,1, 0,-150, 1, H

You can see that there's a pixel of overlap between both frames in Ikemen but not Mugen 1.1. I can see where Suehiro was coming from, though, because Winmugen acts the same as Ikemen. But Mugen 1.1 does seem like the correct way to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants