Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Win type events animations not working for p2 #1819

Open
Seb471 opened this issue May 28, 2024 · 1 comment
Open

Win type events animations not working for p2 #1819

Seb471 opened this issue May 28, 2024 · 1 comment

Comments

@Seb471
Copy link

Seb471 commented May 28, 2024

Describe the bug

When coding in fight.def some special win type for the end of a round, when p2 is winning with a certain win type, instead of using what the animation that was coded for p2, it's using the animation coded for p1.

To Reproduce

  1. Go to a fight.def in the round section.
  2. Create 2 distinct animations at the end of this section (for simplicity's sake), which we'll refer to them as p1anim and p2anim.
  3. Write any type of win (in this example we're going to use for when a player wins with a normal attack, but this has been tested with everything except perfect) like the following :
    p1.n.pos = x,y
    p1.n.bg.anim = p1anim
    p1.n.time = whatever time
    p1.n.displaytime = at least p1anim's length of time

p2.n.pos = x,y
p2.n.bg.anim = p2anim
p2.n.time = whatever time
p2.n.displaytime = at least p2anim's length of time

  1. Open the ikemen go and go to any fight (preferably you should have control of p2)
  2. Press F2 so that you don't wait until you get to low health
  3. p2 finishes p1 with a normal attack
  4. p1anim plays out instead of p2anim

Expected behavior

Instead of using p1's animation for winning with a normal attack in this case, it should be using p2's animation.

Screenshots / Video

2024-05-28.11-48-53.mp4

Engine Version (or source code date)

nightly of the 10th of march 2023 (10/03/2023) but the zip of ikemen go windows version was last updated on the 26/05/2024

Operating system

Windows

Extra context or search terms

No response

@Seb471
Copy link
Author

Seb471 commented May 28, 2024

One more thing : it seems that the normal attack ending also triggers if p2 wins, even if p2's normal attack animation isn't present but p1's is, so it's triggering p1's normal attack finish animation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant