Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix the package format for Windows #53

Merged
merged 1 commit into from
Jul 21, 2024
Merged

ci: fix the package format for Windows #53

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ jobs:
TARBALL_PATH="${PROJECT_NAME}-v${PROJECT_VERSION}-${{ matrix.job.target }}${{ matrix.job.package-extension }}"
echo "TARBALL_PATH=${TARBALL_PATH}" >> "${GITHUB_OUTPUT}"

if [ "${{ matrix.job.os }}" = "windows-2019" ]; then
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build was broken because windows version was updated to windows-2022.

omekasy/.github/workflows/release.yml

Line 37 in 5f526dc

os: "windows-2022",

We should use the regular expression, then the build wouldn't be broken even if windows version will be changed.

This comment was marked as duplicate.

Sign in to view

if [[ "${{ matrix.job.os }}" =~ ^windows- ]]; then
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test

$ [[ "windows-2022" =~ ^windows- ]]; echo $?
0

$ [[ "ubuntu-latest" =~ ^windows- ]]; echo $?
1

7z a "${TARBALL_PATH}" "${PKG_DIR}"
else
tar czf "${TARBALL_PATH}" "${PKG_DIR}"
Expand Down