ci: fix a bug that prebuilt binaries aren't published to GitHub Releases #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omekasy v1.2.1 and v1.2.2 don't have prebuilt binaries. https://github.com/ikanago/omekasy/releases/tag/v1.2.2 Prebuilt binaries were built in CI, but they weren't published because the input of softprops/action-gh-release `files` is empty. https://github.com/ikanago/omekasy/actions/runs/6284001639/job/17064954741 ``` Run softprops/action-gh-release@v1 with: token: *** env: PROJECT_NAME: omekasy PKG_PATH: omekasy-v1.2.2-x86_64-unknown-linux-gnu.tar.gz GITHUB_TOKEN: *** 👩🏭 Creating new GitHub release for tag v1.2.2... 🤔 not include valid file. 🎉 Release ready at https://github.com/ikanago/omekasy/releases/tag/v1.2.2 ```
suzuki-shunsuke
commented
Nov 3, 2023
| @@ -66,7 +66,7 @@ jobs: | |||
| PKG_SUFFIX=".tar.gz" ; case "${{ matrix.job.target }}" in *-pc-windows-*) PKG_SUFFIX=".zip" ;; esac; | |||
| PKG_BASENAME="${PROJECT_NAME}-v${{ steps.project_version.outputs.PROJECT_VERSION }}-${{ matrix.job.target }}" | |||
| PKG_PATH="${PKG_BASENAME}${PKG_SUFFIX}" | |||
| echo "PKG_PATH=${PKG_PATH}" >> "${GITHUB_ENV}" | |||
| echo "PKG_PATH=${PKG_PATH}" >> "${GITHUB_OUTPUT}" | |||
There was a problem hiding this comment.
|
Thank you for your first contribution! |
|
v1.2.3 and the prebuilt binaries are successfully shipped! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
omekasy v1.2.1 and v1.2.2 don't have prebuilt binaries.
https://github.com/ikanago/omekasy/releases/tag/v1.2.2
Prebuilt binaries were built in CI, but they weren't published because the input of softprops/action-gh-release
filesis empty.https://github.com/ikanago/omekasy/actions/runs/6284001639/job/17064954741