Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redid how versioning works. #78

Merged
merged 4 commits into from
May 9, 2024

Conversation

yuki-was-taken
Copy link
Contributor

(BTW I realised that the pull request templates doesn't work, I'll make a commit to fix it. It's probably because Github only allows for one template?)

After the commit where the version option was added, I realised that it had a few problems:

  1. The commit log was flooded with Github Actions commits.
  2. The checks randomly fail because of that step of committing sometime.
  3. The src/catniplib/global/currentcommit.nim file causes merge conflicts due to the numbers being different.

So this PR changes the system in a few ways:

  1. The version is done at compile time, not after pushing.
  2. Github Actions will not need to commit the version number.
  3. The version is obtained by a one line shell script.
  4. src/catniplib/global/currentcommit.nim is added to the .gitignore file in order to not cause any merge conflicts.

@iinsertNameHere iinsertNameHere merged commit 0022605 into iinsertNameHere:main May 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants