-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .tools.res_marg
#277
Draft
khaeru
wants to merge
4
commits into
main
Choose a base branch
from
migrate/res-marg
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add .tools.res_marg
#277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Copied from message_data `ssp_dev` branch - File message_data/scenario_generation/reserve_margin/res_marg.py - Last modified by commit f3efc8b104044676434695aa461d26a7b20e5cd7: Author: FRICKO Oliver <[email protected]> Date: Wed Nov 27 13:48:26 2024 +0100 Update reserve_margin script to remove print statement - message_single_country `SSP_Dev_2023` branch contains an identical file.
- Format docstring according to code style, rewrap. - Add type hints. - Ensure the module appears in the docs. - Add (incomplete) tests for all parts of the code.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #277 +/- ##
========================================
- Coverage 77.6% 65.5% -12.1%
========================================
Files 211 213 +2
Lines 16079 16109 +30
========================================
- Hits 12481 10567 -1914
- Misses 3598 5542 +1944
|
- Integrate with existing `mix-models` CLI. - Remove duplicated code for model/scenario/version arguments, loading platform and scenario, etc. - Simplify tests.
khaeru
added a commit
that referenced
this pull request
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly addresses #275.
This PR does three things:
(1) Copies from message_data
ssp_dev
branch:message_data/scenario_generation/reserve_margin/res_marg.py
SSP_Dev_2023
branch contains an identical file.(2) Adjusts the copied code to confirm, in a minimal way, to the code style:
The above two steps are mandatory for PRs related to #275.
Then, optionally:
(3) Improves the code.
How to review
TBA
PR checklist