Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/cuda height map #521

Open
wants to merge 75 commits into
base: develop
Choose a base branch
from
Open

Conversation

LaughingCommit
Copy link
Contributor

added height map CUDA code

Copy link
Contributor

@TomaszTB TomaszTB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm so happy with this progress. Left a bunch of comments about cleanup and whatnot, but functionality looks good... except for the demo which doesn't work for me :(

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file also needs some cleanup


import java.util.List;

public class RDXRapidHeightMapExtractorCudaDemo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public class RDXRapidHeightMapExtractorCudaDemo
public class RDXRapidHeightMapExtractorCUDADemo

Or whatever change to match the name change of the extractor

@TomaszTB TomaszTB self-requested a review December 10, 2024 19:37
@PotatoPeeler3000 PotatoPeeler3000 dismissed their stale review December 11, 2024 00:47

The flying point should be in a different PR

Copy link
Contributor

@PotatoPeeler3000 PotatoPeeler3000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the flying point commits are removed (to a different branch) this seems great!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should call this CUDAFlyingPointsFilter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants