Sixel display of avatars, media attachments, etc. #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, I need to find some time to try it out. I wouldn't necessarily be against merging it if it's guarded behind a user setting which is disabled by default. |
|
Yes, that makes sense. The code needs cleanup before a merge, particularly the bits in timeline.py need refactoring. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't expect you to merge this PR into master, but it's fun to try out with a properly configured terminal that supports SIXEL images (Xterm works).
You'll need to set fonts up as I do in .Xresources or things won't look correct. I don't have autodetect of font-size-in-pixels yet, so it's hardcoded for these font settings.Don't run under tmux or screen, unless you have a special build of those programs configured to pass through SIXELs.
.Xresources snippet
`
! Use a truetype font and size.
! Cascadia Mono (no PL) should work as well
xtermfaceName: Cascadia Mono PL
xtermfaceSize: 14
xtermbackground: black
xtermforeground: grey
! Sixels support with a matching palette
XTermdecTerminalID: vt340
XTermnumColorRegisters: 256
`