OF-2631: Enforce pubsub node access model #2223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akrherz
force-pushed
the
OF-2631_Pubsub-access-model-leafs
branch
from
9d0109f to
3754ba9
Compare
Fishbowler
previously approved these changes
Oct 3, 2023
Fishbowler
force-pushed
the
OF-2631_Pubsub-access-model-leafs
branch
from
aa591a5 to
8af83fb
Compare
|
Rebased. |
Fishbowler
force-pushed
the
OF-2631_Pubsub-access-model-leafs
branch
from
8af83fb to
f1ebd5d
Compare
|
Rebased |
When items on a pubsub leaf node are processed, ensure that the access model of the node itself (and not just its collection) are taken into account.
Fishbowler
force-pushed
the
OF-2631_Pubsub-access-model-leafs
branch
from
f1ebd5d to
74e89a5
Compare
|
Rebased |
|
Did we address this somewhere else via other means? Or am I imagining this? |
|
No, you didn't. I've observed the problem to exist in 5.0.0-SNAPSHOT. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When items on a pubsub leaf node are processed, ensure that the access model of the node itself (and not just its collection) are taken into account.