Commenting app.js for clarity #1053
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added some comments for clarity of middlewares
Loujayna1
reviewed
Apr 11, 2024
backend/src/app.js
Outdated
| @@ -2,43 +2,43 @@ const express = require('express'); | |||
|
|
|||
There was a problem hiding this comment.
maybe it's better if you add this comment here:
// Import required packages
Loujayna1
reviewed
Apr 11, 2024
| @@ -2,43 +2,43 @@ const express = require('express'); | |||
|
|
|||
| const cors = require('cors'); | |||
| const compression = require('compression'); | |||
|
|
|||
| const cookieParser = require('cookie-parser'); | |||
|
|
|||
There was a problem hiding this comment.
and here:
// Import routers and controllers
Loujayna1
reviewed
Apr 11, 2024
backend/src/app.js
Outdated
| // create our Express app | ||
| const app = express(); | ||
|
|
||
| // enable CORS with specific options | ||
| app.use( | ||
| cors({ | ||
| origin: true, |
There was a problem hiding this comment.
here you can add:
// Allow requests from any origin
Loujayna1
reviewed
Apr 11, 2024
backend/src/app.js
Outdated
| // create our Express app | ||
| const app = express(); | ||
|
|
||
| // enable CORS with specific options | ||
| app.use( | ||
| cors({ | ||
| origin: true, | ||
| credentials: true, |
There was a problem hiding this comment.
and here:
// Allow sending cookies along with requests
Loujayna1
reviewed
Apr 11, 2024
| app.use(cookieParser()); | ||
| app.use(express.json()); | ||
| app.use(express.urlencoded({ extended: true })); | ||
|
|
There was a problem hiding this comment.
here you can add:
// Compress HTTP responses
updated app.js according to review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some comments for clarity of middlewares
Description
-- Changed adminAuth to coreAdminAuth to keep up with the file trend.
-- added some comments for basic clarity
Note - This is my first pull request so I'm sorry if it silly, i do hope it gets merged. Thank you for letting me contribute(even if its just commenting).
Steps to Test
no need
Checklist