Fix:-Bug: Company Name and Phone fields accept misleading input #1047 #1050
Conversation
some code changes
code commit
Update to 4.0.0-beta.3
removed wrong code
Updated invoice title
Updated space
Updated content
Added discount option in code
Fix Adding new admin bug
added address in customer
Branch discount
Revert "Branch discount"
Fixed typo in readme.md
This commit addresses an issue in the frontend Dockerfile where the `CMD` directive attempted to execute `npm run local`, a script that doesn't exist in `package.json`. This discrepancy caused the Docker container for the frontend to fail to start, hindering the setup process for developers and contributors working with Docker. Changes made: - Updated the `CMD` in the Dockerfile to use `npm run dev -- --host 0.0.0.0`, aligning it with the available scripts defined in `package.json` and ensuring the development server listens on all network interfaces within the Docker container. This adjustment facilitates access to the frontend service from the host machine or other Docker containers. Verification: - Rebuilt the Docker image for the frontend and verified that the container starts successfully and is accessible on `http://localhost:3000`. - Ensured that the frontend application functions as expected when accessed through the browser. This fix streamlines the developer experience by ensuring the Docker setup process is smooth and aligns with the project's current frontend tooling configuration.
This reverts commit 681f175.
This commit addresses an issue in the frontend Dockerfile where the `CMD` directive attempted to execute `npm run local`, a script that doesn't exist in `package.json`. This discrepancy caused the Docker container for the frontend to fail to start, hindering the setup process for developers and contributors working with Docker. Changes made: - Updated the `CMD` in the Dockerfile to use `npm run dev -- --host 0.0.0.0`, aligning it with the available scripts defined in `package.json` and ensuring the development server listens on all network interfaces within the Docker container. This adjustment facilitates access to the frontend service from the host machine or other Docker containers. Verification: - Rebuilt the Docker image for the frontend and verified that the container starts successfully and is accessible on `http://localhost:3000`. - Ensured that the frontend application functions as expected when accessed through the browser. This fix streamlines the developer experience by ensuring the Docker setup process is smooth and aligns with the project's current frontend tooling configuration.
Fix: Update Dockerfile to use correct npm script for frontend service
fix 'req is undefined' error in payment controller
|
Thanks for your work @vr1Ravi but i just tested your index.js and unfortunately i'm still able to enter misleading inputs. |
|
@inesmrad I see, can you tell me which browser you are using. |
i'm using Chrome version 123.0.6312.106 |
|
@inesmrad, could you check it now. |
|
@inesmrad , could you please review the code I wrote. looking for your feedback. |
|
Hey @vr1Ravi , your PR works perfectly , but i also have a small suggestion .You know when i try to input a number in the Name field, the numbers part of the keyboard is kinda blocked. Wouldn't it be more helpful to keep it this way but also to display a clear error message so that users don't get confused. The error message will help users understand why their input is not accepted, reducing confusion and improving the overall user experience. What do you think ? |
|
Yes you are right. User might think "is something wrong with my kep board or app". A perfect error message will definetly enhance the UX. Let me try to add it. |
Awesome !! |
|
Hey @inesmrad, I did add the error message. Could you see if everything is ok. |
|
Hey @inesmrad, looking for your feedback on the latest change that I've made. |
|
@inesmrad, need little information, can you tell me in phone filed your are able to type any alphabate or only 'e'. Right now I've opend the repo and saw that for one time i am able to enter 'e' only. If you tell me the exact behaviour it would be helpful for me |
i'm able to type 'e' and ',' (comma) and i'm not getting an error message if i try to type another character, the keyboard is simply blocked |
Could you check it now. This time I've added error message too and tell me if we need to change the content of error message. |
All good , it's working perfectly fine now, thank you for your work ! |
Great to hear that everything is working perfectly now! You're welcome, happy to help! |
Description
Inside forms/DynamicForm, index.js. I've added onKeyDown event to contry and search component to prevent meleading input values.