Wrong user creation #68 #135
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicsufer
requested review from
sorobon,
vicsufer,
blalop,
caldito,
dortegau,
emepege,
frantsao,
jmonterrubio,
jperera,
ultraheroe and
xtianae7
|
Thanks for the contribution @denics, it looks great to me. Please update |
emepege
approved these changes
Aug 16, 2021
vicsufer
approved these changes
Aug 16, 2021
xtianae7
approved these changes
Aug 16, 2021
|
Dear @vicsufer the patch is good but it seems there is a problem with the pipeline, all PR are failing in Travis CI. Can somebody have a look? |
|
After hours spent, I discovered that, at least on debian 10, solr must be able to login at least in /bin/sh to launch solr from init.d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
it seems that the script is using the shell as home for the creation of the solr user and this does not work on debian based systems. with this patch I propose to add a var
solr_user_shellto define the shell (like suggested in https://www.mail-archive.com/[email protected]/msg128029.html) and to add the home argument in the install ansible to create the user solr with the definedsolr_homevariable.Benefits
The script will be even better
Possible Drawbacks
None
Applicable Issues
#68