-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Streams instead of callbacks #19
Open
iconara
wants to merge
23
commits into
master
Choose a base branch
from
streams
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A connection is a stream of the data chunks received by the socket
I’m pretty pleased with the state machine approach to parsing the Redis protocol. It’s a few more lines than would be strictly necessary because of all the classes, but it’s always nice with a state machine.
This is the remains of an earlier implementation.
It’s really a naïve Redis client implementation
Because Future::Combinators and not Future::FutureCombinators (any more)
I’m not really sure how to formulate it, but this feels better than the current wording.
* Stream#subscribe now takes a Subscriber * PushStream is renamed Source and has a #<< for publishing * #subscribe and #unsubscribe are encapsulated in Publisher * The private #deliver method of Stream has been encapsulated in a class called Processor, which is both a Publisher and a Subscriber, and rename it #call * The combinators have been rewritten to be Sources
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add streams (push streams for the moment, not reactive streams), and replace some of the event listeners with them.
This enables a new style of protocol handlers: