Optimized future combinators #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iconara
force-pushed
the
optimize_future_combinators
branch
from
b08adea to
84cb1c1
Compare
Early return has a cost in JRuby, not big but still a cost.
Wait only for one future at a time. Once the first future has completed, wait for the next one, and so on (short-circuiting when the first fails). Since we have to wait for them all anyway it doesn’t really matter if we wait for all of them at the same time, or one by one. Once the first future has completed it’s likely that many of the other have also completed, and calling their #on_complete will be cheaper.
Moving them to CompletableFuture allows much more compact expression of the combinators.
This significantly cuts the implementation size by and should not introduce too much function call overhead.
Out of the combinators, this is the only case that does not rely on pre-existing futures, auto detection, or rescuing errors, so the extra verbosity seems like a reasonable trade-off.
iconara
force-pushed
the
optimize_future_combinators
branch
from
6475a0d to
222f1bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the receiving future is completed many of the combinator methods can be optimized to avoid creating intermediate futures.
This is a work in progress, it basically doubles the size of complexity of the methods.