Fix incorrect predicate in PermissionControllerImpl on Android #137
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #105 permission state
NotGranted
is introduced and the negation when checkingshouldShowRequestPermissionRationale
is removed.The desired result in that change is to return
PermissionState.Denied
in case thatshouldShowRequestPermissionRationale
returnstrue
for all permissions, andPermissionState.NotGranted
otherwise. That is correct behavior according to the documentationHowever, in PR #115, possibly due to conflict resolution, the negation is brought back, while the return statement stays as it was in #105, resulting in the default state of the permission to be
Denied
(instead of NotGranted), which is incorrect.