Skip to content

Commit

Permalink
Merge pull request #8 from icerockdev/develop
Browse files Browse the repository at this point in the history
0.3.1 release
  • Loading branch information
Alex009 committed Oct 30, 2019
2 parents a355d61 + 3e00d92 commit c91d2b0
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 6 deletions.
5 changes: 3 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ This is a Kotlin Multiplatform library that provides architecture components of
- 0.1.0
- 0.2.0
- 0.3.0
- 0.3.1

## Installation
root build.gradle
Expand All @@ -45,7 +46,7 @@ allprojects {
project build.gradle
```groovy
dependencies {
commonMainApi("dev.icerock.moko:mvvm:0.3.0")
commonMainApi("dev.icerock.moko:mvvm:0.3.1")
}
```

Expand All @@ -56,7 +57,7 @@ enableFeaturePreview("GRADLE_METADATA")

On iOS, in addition to the Kotlin library add in Podfile
```ruby
pod 'MultiPlatformLibraryMvvm', :git => 'https://github.com/icerockdev/moko-mvvm.git', :tag => 'release/0.3.0'
pod 'MultiPlatformLibraryMvvm', :git => 'https://github.com/icerockdev/moko-mvvm.git', :tag => 'release/0.3.1'
```
**`MultiPlatformLibraryMvvm` CocoaPod requires that the framework compiled from Kotlin be named
`MultiPlatformLibrary` and be connected as a CocoaPod `MultiPlatformLibrary`.
Expand Down
2 changes: 1 addition & 1 deletion buildSrc/src/main/kotlin/Versions.kt
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ object Versions {
const val coroutines = "1.3.0"
const val mokoCore: String = "0.1.0"
const val mokoResources: String = "0.3.0"
const val mokoMvvm: String = "0.3.0"
const val mokoMvvm: String = "0.3.1"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ actual open class ViewModel actual constructor() : ViewModel() {
// for now dispatcher fixed on Main. after implementing multithread coroutines on native - we can change it
protected actual val viewModelScope: CoroutineScope = CoroutineScope(Dispatchers.Main)

actual override fun onCleared() {
public actual override fun onCleared() {
super.onCleared()

viewModelScope.cancel()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,5 @@ import kotlinx.coroutines.CoroutineScope
expect open class ViewModel() {
protected val viewModelScope: CoroutineScope

protected open fun onCleared()
open fun onCleared()
}
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ actual open class ViewModel actual constructor() {
// for now dispatcher fixed on Main. after implementing multithread coroutines on native - we can change it
protected actual val viewModelScope: CoroutineScope = CoroutineScope(UIDispatcher())

protected actual open fun onCleared() {
actual open fun onCleared() {
viewModelScope.cancel()
}
}

0 comments on commit c91d2b0

Please sign in to comment.