Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add system dialog to enable GPS #15

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Add system dialog to enable GPS #15

wants to merge 4 commits into from

Conversation

ln-12
Copy link

@ln-12 ln-12 commented Jan 11, 2021

This pull request is related to issue #14

It makes use of the relatively new contracts API on Android to request a system dialog for enabling GPS after the permission was granted. At the moment, I cannot provide an example for iOS.

@ln-12 ln-12 mentioned this pull request Jan 11, 2021
Open
@Alex009 Alex009 linked an issue Jan 12, 2021 that may be closed by this pull request
Android - add dialog to enable GPS #14
Open
Alex009
Alex009 requested changes Mar 29, 2021
View reviewed changes
buildSrc/src/main/kotlin/Deps.kt Outdated Show resolved Hide resolved
buildSrc/src/main/kotlin/Deps.kt Outdated Show resolved Hide resolved
geo/build.gradle.kts Outdated Show resolved Hide resolved
geo/src/androidMain/kotlin/dev/icerock/moko/geo/GPSLifecycleObserver.kt Show resolved Hide resolved
geo/src/androidMain/kotlin/dev/icerock/moko/geo/GPSSensorHelper.kt Show resolved Hide resolved
@Alex009 Alex009 added this to the 0.4.0 milestone Mar 29, 2021
@Alex009
Copy link
Member

Alex009 commented Mar 29, 2021

also i should add ios implementation

@Alex009 Alex009 self-assigned this Mar 29, 2021
@Alex009 Alex009 changed the base branch from master to develop March 29, 2021 05:33
@ln-12
Copy link
Author

ln-12 commented Mar 29, 2021

I fixed all your suggestions.

@anton6tak anton6tak modified the milestones: 0.4.0, 0.5.0 Jul 1, 2021
@Alex009 Alex009 removed this from the 0.5.0 milestone Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alex009 Alex009 Alex009 requested changes

Assignees

@Alex009 Alex009

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Android - add dialog to enable GPS
3 participants
@ln-12 @Alex009 @anton6tak