Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android - add dialog to enable GPS #14

Open
ln-12 opened this issue Jan 8, 2021 · 3 comments · May be fixed by #15
Open

Android - add dialog to enable GPS #14

ln-12 opened this issue Jan 8, 2021 · 3 comments · May be fixed by #15
Labels
enhancement New feature or request

Comments

@ln-12
Copy link

ln-12 commented Jan 8, 2021

I tested this library on Android. It works perfectly fine, if GPS is enabled. If not, nothing happens. The official docs state that an app should check the settings and prompt a system dialog to enable GPS. Would be nice to see this feature.
@Alex009 Alex009 added the enhancement New feature or request label Jan 10, 2021
@Alex009
Copy link
Member

Alex009 commented Jan 10, 2021

yes, it will be good improvement

@ln-12 ln-12 linked a pull request Jan 11, 2021 that will close this issue
Open
@ln-12
Copy link
Author

ln-12 commented Jan 11, 2021 •
edited
Loading

Hey, I quickly created a pull request for the requested feature based on the code I already use in my app. Feel free to use it as a baseline for your implementation. At the moment, I have no option to run code on iOS, so I cannot provide an example for that.

@Alex009
Copy link
Member

Alex009 commented Jan 12, 2021

thx! we pull it later

@Alex009 Alex009 linked a pull request Jan 12, 2021 that will close this issue
Add system dialog to enable GPS #15
Open
@Alex009 Alex009 added this to the 0.4.0 milestone Mar 29, 2021
@Alex009 Alex009 removed this from the 0.4.0 milestone Jun 25, 2021
@anton6tak anton6tak modified the milestone: 0.5.0 Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add system dialog to enable GPS ln-12/moko-geo
3 participants
@Alex009 @ln-12 @anton6tak