Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Add-on store problems #257

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix Add-on store problems #257

wants to merge 3 commits into from

Conversation

magicus
Copy link

@magicus magicus commented Nov 1, 2022

Converting the config.json to config.yaml seems to be the first step towards resolving #256. There seems to be additional hurdles, though.

@magicus magicus marked this pull request as ready for review November 1, 2022 08:55
@magicus
Copy link
Author

magicus commented Nov 1, 2022

Ok, this patch more or less works now (as far as I can tell; it installed the Add-on on my system). There is one problem that I did not know how to best resolve, though. For logging purposes, the information from config.json were read into an AddonInfo object in Configuration.js.

But now the file is in YAML format, so the JSON.parse() method will not handle it. (I presume)

I have some ideas on how to resolve this, none is ideal so I'd like feedback, and/or that @icanos takes over this PR and fixes this part.

  1. Keep a copy of the info in config.json as well
  2. Keep the format in pure json even if the file is named config.yaml (this is legal but not recommended)
  3. Skip the logging and remove this code
  4. Add a yaml parser, like js-yaml to the installation (this is the preferred option I think)

@e120guru
Copy link

Has there been any more progress on this to get it to show up in the Addon Store?

@e120guru
Copy link

Ok, after a reboot or two it all of a sudden showed up

@SweVictor
Copy link
Collaborator

@e120guru @magicus - so... It IS showing up without the need for the requested change in the linked PR?

@magicus
Copy link
Author

magicus commented Aug 14, 2023

I honestly don't remember if I managed to get it working without this patch, or if I am still running a patched version on my hass installation, based on my personal repo. But if other users get it to work without the patch, I guess it is not needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants