Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HistoryCommits refactoring and UI tweaks #28

Merged
merged 1 commit into from May 18, 2024

Conversation

MichalHecko
Copy link

Hi,

first think i am gonna do is tweaking a little of how commits history looks like at all. Needs a little polish here and there and i did a small code review. This is just a draft, need a little thinks to do in next days.

Few improvements of UI:

  1. Merge commit lanes column with commit messages column together
  2. Remove refs column and make ref be part of - before commit message (as a badges with icons)
  3. Make commit lanes with message column to fit the rest of table with automagically

Small example, where i am right now - not final version of course (i am gonna polish UI of commits more and more).

Screenshot from 2024-05-08 09-43-20

Code review:

  1. Make a history commit view more modular - moving to separe packages by functionalities (i.e. move to module/histry with FXML files, ...), lots of annonyous classes as lambdas or classes (handlers, factories, listeners, ...)
  2. I just start with history commit, plan is to modularize all views within separate packages consist of controllers, services, factories, helpers, data object, ...

Give me feedback what you think about it.

Be prepare for more PR after this, i.e. Lombok in all project, more refactoring how this project is organized, ...

@iazarny iazarny marked this pull request as ready for review May 17, 2024 13:53
@iazarny iazarny merged commit 12f2b75 into iazarny:master May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants