fix: allow to use ReadonlyDate in ConfigType #2751
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request introduces support for the
ReadonlyDate
type as a valid input for thedayjs()
function. TheReadonlyDate
type excludes all setter methods from the nativeDate
object, ensuring immutability.The aim is to allow dates that are typed as
ReadonlyDate
in projects to be directly passed to the dayjs() function without compatibility issues.Benefits
ReadonlyDate
objects (which exclude setter methods for immutability) as input to thedayjs()
function, ensuring smooth integration with projects that require or enforce readonly types.Impact
Date
and other types as input todayjs()
will continue to work as expected.ReadonlyDate
in their projects to seamlessly integratedayjs()
without needing to cast or modify their date types.