Supporting Relative url in VectorTile Style file #2455
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ftoromanoff
changed the title
ftoromanoff
force-pushed
the
relativeUrl
branch
from
9ea568c to
3b370a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UPDATE: The modification done here were reused in the PR global about VT #2469.
Linked to issue #2454 .
ArcGis VectorTile server uses relative url to point the localisation of sprite and tile in the style.json file.
This PR aims at fixing that issue.
A second bug where the url given should already be writing with the $ has been fixed as well as adding a warning when some icons where not found in the sprite sheet giving in the style file.