fix vertical problems in polygons triangulation #1729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmaillet
force-pushed
the
fix3DTriangulation
branch
from
0a5cd2e to
36010e0
Compare
gchoqueux
reviewed
Oct 28, 2021
gmaillet
force-pushed
the
fix3DTriangulation
branch
from
36010e0 to
59be18c
Compare
gmaillet
force-pushed
the
fix3DTriangulation
branch
from
59be18c to
fc8642f
Compare
gmaillet
force-pushed
the
fix3DTriangulation
branch
from
fc8642f to
f740f1c
Compare
|
may be invert default value for option. |
|
could you add example? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using an average plane for polygons triangulation.
Motivation and Context
In featureToPolygon (Feature2Mesh.js) polygons are triangulate with earcut to create a BufferGeometry. This is a 2D triangulation method and it doesn't work on vertical faces.