feature(Style): points can now be displayed as icons #1715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgermerie
force-pushed
the
feature-points
branch
2 times, most recently
from
72fb2f7 to
8250e82
Compare
gchoqueux
reviewed
Oct 6, 2021
src/Layer/LabelLayer.js
Outdated
Comment on lines
97
to
85
| this.style.icon = this.style.icon || {}; | ||
| this.style.icon.source = canvas.toDataURL(); | ||
| this.style.point.color = undefined; | ||
| this.style.point.line = undefined; |
There was a problem hiding this comment.
I'm not sure to keep this part....
There was a problem hiding this comment.
Changing this.style.icon.source is necessary so that the canvas drawing is displayed as icon. The following two lines prevent drawing points projected on ground, as can be seen in the attached screenshot. Moreover, they do not actually change the Style object defined by the user. Do you still think I should remove them ?
mgermerie
force-pushed
the
feature-points
branch
from
8250e82 to
7ed379f
Compare
mgermerie
force-pushed
the
feature-points
branch
from
7ed379f to
377e739
Compare
mgermerie
force-pushed
the
feature-points
branch
2 times, most recently
from
959624c to
4ea5fef
Compare
mgermerie
force-pushed
the
feature-points
branch
3 times, most recently
from
1ef6de6 to
5041fcb
Compare
mgermerie
force-pushed
the
feature-points
branch
7 times, most recently
from
5e6c230 to
eb581e6
Compare
mgermerie
force-pushed
the
feature-points
branch
4 times, most recently
from
d05e7ed to
8632725
Compare
mgermerie
force-pushed
the
feature-points
branch
9 times, most recently
from
5431108 to
cc5de42
Compare
mgermerie
force-pushed
the
feature-points
branch
from
cc5de42 to
628a6bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support to display points as label icons in a
ColorLayeror aLabelLayer.If user defines
Style.pointof aColorLayer, and set theColorLayeraddLabelLayerparameter to true, points will be displayed as label icons. IfaddLabelLayeris unset or set to false, point will be kept rasterized.User can also define
Style.pointfor aLabelLayer, in which case points will obviously be displayed as label icons.