Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Resolve Duplicate scope and scope_delimiter Parameters in SocialLoginSerializer #670

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Jeihunn
Copy link

@Jeihunn Jeihunn commented Dec 1, 2024

Problem

The SocialLoginSerializer passes both scope and scope_delimiter to the OAuth2Client constructor, causing a TypeError due to duplicate arguments for scope_delimiter.

Solution

  • Removed the redundant scope parameter while preserving scope_delimiter.
  • Ensured seamless integration with OAuth2 providers.

Impact

This resolves the error and ensures compatibility with OAuth2 flows like Google Login. The fix is backward-compatible and does not affect other functionalities.

Visuals

dj-rest-auth scope_delimiter bug
OAuth2Client init method
SocialLoginSerializer multiple scope_delimiter

…LoginSerializer's OAuth2Client initialization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant