Migrate Fullchain tests to Hardhat and convert them to full integration tests #156
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #156 +/- ##
==========================================
Coverage ? 84.67%
==========================================
Files ? 35
Lines ? 1083
Branches ? 201
==========================================
Hits ? 917
Misses ? 166
Partials ? 0 ☔ View full report in Codecov by Sentry. |
|
|
||
| it('[5] No sponsorship, no beneficiary, no callback, no BoT, no replication', async function () {}); | ||
|
|
||
| describe.skip('MatchOrders', function () { |
There was a problem hiding this comment.
Why skip it instead of removing it?
There are ts issues. Maybe we could add something like // @ts-nocheck if we don't want to remove it.
There was a problem hiding this comment.
I didn't remove the file to respect a "PR size" metric that we have defined in the past. We can discuss it offchain.
I will add the annotation yes, it's a good idea.
There was a problem hiding this comment.
It seems the annotation can only be added to the hole file.
Instead of adding it I will remove the block in the next PR.
No description provided.