types(Trans): add typechecking on context
prop
#1732
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1730.
This is technically a breaking change since it change
Trans
andTransProps
type parameters, however I don't think usually people explicit them when using the component... but who knows 馃し.I tried to replicate a type parameter structure similar to the
TFunction
,however, looks like that using a single
TOpt
type parameter doesn't pass the property values (likecontext
) down toTransProps
properly soParseKeys
is not aware of the context value.The only alternative is to add a new type parameter and pass it down the chain, which is basically what @stefan-schweiger proposed in the above linked issue (Thanks 馃檹).
Checklist
npm run test