Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: trim keys once #2194

Merged
merged 1 commit into from
May 20, 2024
Merged

perf: trim keys once #2194

merged 1 commit into from
May 20, 2024

Conversation

VIKTORVAV99
Copy link
Contributor

Trims the key once and reuse it rather than calling trim multiple times. Also moves the logic inside the if condition instead of using an early return since it's the only logic in there.

This should improve both the performance and bundle size a tiny bit.

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included
  • commit message and code follows the Developer's Certification of Origin

Checklist (for documentation change)

  • only relevant documentation part is changed (make a diff before you submit the PR)
  • motivation/reason is provided
  • commit message and code follows the Developer's Certification of Origin

@coveralls
Copy link

Coverage Status

coverage: 96.317% (+0.004%) from 96.313%
when pulling bea33b4 on VIKTORVAV99:trim_keys_once
into 20011af on i18next:master.

@adrai adrai merged commit c5c6291 into i18next:master May 20, 2024
9 checks passed
@adrai
Copy link
Member

adrai commented May 20, 2024

included in v23.11.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants