Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Use optional chaining #2184

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

VIKTORVAV99
Copy link
Contributor

As mentioned in #2181 this PR changes the code to use optional chaining. This PR is expected to stay open until the maintainers make a new major release that drops support for Node 12.

These changes should improve performance by reducing property access and will make the minimised code bundle smaller. These changes have not been benchmarked.

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included
  • commit message and code follows the Developer's Certification of Origin

Checklist (for documentation change)

  • only relevant documentation part is changed (make a diff before you submit the PR)
  • motivation/reason is provided
  • commit message and code follows the Developer's Certification of Origin

@coveralls
Copy link

Coverage Status

coverage: 96.3% (-0.01%) from 96.313%
when pulling 00ff5d5 on VIKTORVAV99:optional_chaining
into 9ce9150 on i18next:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants