Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tax excluding and including in Checkout #145

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

jladmore
Copy link
Contributor

I have implemented some of the tax information in the cart.

Added the necessary config options in data-config_checkout
referenced these within the react container
added both tax options where possible in the graphql calls
conditionally display the options in items, shipping and totals.

There are some things I can't do due to the lack of support in Graphql. This is described here
magento/magento2#33848
So we will have to wait before this is a complete implementation. I have also left off the option of displaying both exTax and incTax values. At this stage it is either one.

I have tested in my environment. but as this is configured for Australia GST I am sure there maybe issues.

@wigman
Copy link
Contributor

wigman commented Sep 10, 2021

This looks good to me, what do you think @progammer-rkt ? Do we want this in the RC, or postpone until we have everything released as stable?

@rajeev-k-tomy
Copy link
Collaborator

@wigman @jladmore This needs to be considered in the future release. This is a good PR. But, there are rooms for improvement. I will add comments on this PR once we released the major version here.

@wigman
Copy link
Contributor

wigman commented Sep 10, 2021

I agree. good. Thanks a lot for the contribution @jladmore! We'll get back to this!

@peterjaap
Copy link
Contributor

This PR needs some attention. For most European countries, you are legally obligated to show the VAT amount. So we can't start using this checkout without this change.

@jesse-deboer
Copy link
Contributor

Looks really good, maybe needs a little bit of refactoring like not needing to get all the settings individually but make an object of taxIncluded for example:

taxIncluded:  {
    shippingPriceTax: false
    itemPricesTax: true
    subTotalTax: false
}

Stores that are in Europe and USA for example really need this one and the implementation works really good this way!

@wigman wigman added enhancement New feature or request help wanted Extra attention is needed labels Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants