-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix EELSArctan
gradients
#55
Fix EELSArctan
gradients
#55
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55 +/- ##
==========================================
+ Coverage 87.77% 88.49% +0.72%
==========================================
Files 67 67
Lines 7287 7286 -1
Branches 1179 1179
==========================================
+ Hits 6396 6448 +52
+ Misses 626 568 -58
- Partials 265 270 +5 ☔ View full report in Codecov by Sentry. |
40c253a
to
a303cb2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor suggestions for better readability of some of the docstrings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good, except that the changelog does not include the documentation improvements.
Co-authored-by: Jonas Lähnemann <[email protected]>
a41acf0
to
41acbcf
Compare
Same as hyperspy/hyperspy#3388.
Progress of the PR
EELSArctan
gradients,upcoming_changes
folder (seeupcoming_changes/README.rst
),docs/readthedocs.org:exspy
build of this PR (link in github checks)