Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cumulative_trapezoid instead of cumtrapz #40

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

ericpre
Copy link
Member

@ericpre ericpre commented Apr 9, 2024

In #33, I missed one deprecation (see https://github.com/hyperspy/hyperspy-extensions-list/actions/runs/8612136996/job/23600692746).

I couldn't find it in the scipy release notes but the relevant issue/PR are scipy/scipy#18702 and scipy/scipy#18699.

Progress of the PR

  • Use cumulative_trapezoid instead of cumtrapz,
  • [n/a] docstring updated (if appropriate),
  • [n/a] update user guide (if appropriate),
  • [n/a] added tests,
  • [n/a] add a changelog entry in the upcoming_changes folder (see upcoming_changes/README.rst),
  • [n/a] Check formatting of the changelog entry (and eventual user guide changes) in the docs/readthedocs.org:exspy build of this PR (link in github checks)
  • ready for review.

@ericpre ericpre added this to the v0.2 milestone Apr 9, 2024
@ericpre ericpre requested a review from jlaehne April 9, 2024 08:35
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.47%. Comparing base (6412ba7) to head (77b0dfa).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #40   +/-   ##
=======================================
  Coverage   88.47%   88.47%           
=======================================
  Files          67       67           
  Lines        7287     7287           
  Branches     1179     1179           
=======================================
  Hits         6447     6447           
  Misses        571      571           
  Partials      269      269           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jlaehne jlaehne merged commit 89810e3 into hyperspy:main Apr 9, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants