Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate packaging in pyproject.toml #10

Merged
merged 10 commits into from
Nov 14, 2023

Conversation

ericpre
Copy link
Member

@ericpre ericpre commented Nov 1, 2023

Needs hyperspy/hyperspy#3252 to work in editable installation mode (pip -e). Non-editable pip installation works fine.
The motivation for this changes to consolidate package metadata in pyproject.toml and use modern package building approach, which are now fairly well established.

Progress of the PR

  • Consolidate packaging in pyproject.toml and remove setup.py,
  • fix formatting,
  • [n/a] docstring updated (if appropriate),
  • [n/a] update user guide (if appropriate),
  • [n/a] added tests,
  • added line to CHANGES.rst,
  • ready for review.

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b8c0de6) 91.75% compared to head (165217d) 91.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #10      +/-   ##
==========================================
+ Coverage   91.75%   91.87%   +0.11%     
==========================================
  Files          69       67       -2     
  Lines        7279     7274       -5     
==========================================
+ Hits         6679     6683       +4     
+ Misses        600      591       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ericpre ericpre merged commit 987e6a8 into hyperspy:main Nov 14, 2023
16 checks passed
@ericpre ericpre mentioned this pull request Nov 25, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants