Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove .vscode settings #66

Merged
merged 3 commits into from
Nov 18, 2024

Conversation

simongdavies
Copy link
Contributor

@simongdavies simongdavies commented Nov 18, 2024

Removes .vscode directory from repo

closes #49

README.md Outdated Show resolved Hide resolved
ludfjig
ludfjig previously approved these changes Nov 18, 2024
Copy link
Contributor

@ludfjig ludfjig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor question

src/hyperlight_host/Cargo.toml Outdated Show resolved Hide resolved
danbugs
danbugs previously approved these changes Nov 18, 2024
.devcontainer/Dockerfile Outdated Show resolved Hide resolved
@simongdavies simongdavies force-pushed the remove-vscode-settings branch 3 times, most recently from ec3ee33 to 426f8e3 Compare November 18, 2024 22:17
@simongdavies simongdavies enabled auto-merge (squash) November 18, 2024 22:18
simongdavies and others added 3 commits November 18, 2024 23:24
Signed-off-by: Simon Davies <[email protected]>
Co-authored-by: Dan Chiarlone <[email protected]>
Signed-off-by: Simon Davies <[email protected]>
@simongdavies simongdavies force-pushed the remove-vscode-settings branch from 426f8e3 to 639c514 Compare November 18, 2024 23:27
@simongdavies simongdavies merged commit 8cec8c0 into hyperlight-dev:main Nov 18, 2024
13 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

git rm -r .vscode
3 participants