Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Modifying logo image in README to use an absolute path #27

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

danbugs
Copy link
Contributor

@danbugs danbugs commented Nov 7, 2024

Currently, our logo doesn't show on crates.io. This is because we are using a relative path to the image. This PR changes the path of the image to be an absolute path. For more info, see: rust-lang/crates.io#982.

Currently, our logo doesn't show on crates.io. This is because we are using a relative path to the image. This PR changes the path of the image to be an absolute path. For more info, see: rust-lang/crates.io#982.

Signed-off-by: danbugs <[email protected]>
@danbugs danbugs added the chore label Nov 7, 2024
@danbugs danbugs assigned ludfjig and marosset and unassigned ludfjig and marosset Nov 7, 2024
@danbugs danbugs requested review from ludfjig and marosset November 7, 2024 00:47
Copy link
Contributor

@devigned devigned left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@danbugs danbugs enabled auto-merge (squash) November 7, 2024 01:04
@danbugs danbugs changed the title [chore] Modying logo image in README to use an absolute path [chore] Modifying logo image in README to use an absolute path Nov 7, 2024
@danbugs danbugs merged commit 5de7c90 into main Nov 7, 2024
16 checks passed
@danbugs danbugs deleted the danbugs/using-absolute-path-to-logo-image-in-readme branch November 7, 2024 03:07
danbugs added a commit to danbugs/hyperlight that referenced this pull request Nov 7, 2024
…ght-dev#27)

Currently, our logo doesn't show on crates.io. This is because we are using a relative path to the image. This PR changes the path of the image to be an absolute path. For more info, see: rust-lang/crates.io#982.

Signed-off-by: danbugs <[email protected]>
danbugs added a commit to danbugs/hyperlight that referenced this pull request Nov 7, 2024
…ght-dev#27)

Currently, our logo doesn't show on crates.io. This is because we are using a relative path to the image. This PR changes the path of the image to be an absolute path. For more info, see: rust-lang/crates.io#982.

Signed-off-by: danbugs <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants