-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[performance] Move set_up_hypervisor_partition
to inside the hv handler thread
#26
[performance] Move set_up_hypervisor_partition
to inside the hv handler thread
#26
Conversation
1c4354a
to
3e2bb6a
Compare
set_up_hypervisor_partition
to inside the hv handler threadset_up_hypervisor_partition
to inside the hv handler thread and increase our test matrix to include intel runners
set_up_hypervisor_partition
to inside the hv handler thread and increase our test matrix to include intel runnersset_up_hypervisor_partition
to inside the hv handler thread and increase our test matrix to include Intel runners
9ec82f1
to
3e2bb6a
Compare
set_up_hypervisor_partition
to inside the hv handler thread and increase our test matrix to include Intel runnersset_up_hypervisor_partition
to inside the hv handler thread
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job, I will be intersting to see if this increases performance :D. Just some minor questions
EDIT: also noticed this PR has github-actions in the PR title which I think might be inaccurate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be simplified a little bit, and avoid some extra synchronisation and potential issues with aliasing the shared memory.
set_up_hypervisor_partition
to inside the hv handler threadset_up_hypervisor_partition
to inside the hv handler thread
4a56fcf
to
ff1ec39
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…er thread As per KVM docs, vCPU ioctls should be issued from the same thread that was used to create the vCPU. In accordance to that, this PR moves set_up_hypervisor_partition to inside the hv handler thread, which manages vCPU interactions like init and dispatching guest funciton calls. Signed-off-by: danbugs <[email protected]>
ff1ec39
to
e39936a
Compare
As per KVM docs, vCPU ioctls should be issued from the same thread that was used to create the vCPU. In accordance to that, this PR moves
set_up_hypervisor_partition
to inside the hv handler thread, which manages vCPU interactions like init and dispatching guest funciton calls.